video: fix dcmipp devicetree #94400
video: fix dcmipp devicetree #94400
Conversation
The driver instance variable name is inst, not n. Signed-off-by: Phi Bang Nguyen <[email protected]>
zephyrbot
added
platform: STM32
zephyrbot
requested review from
avisconti,
avolmat-st,
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no,
josuah,
kartben,
loicpoulain,
marwaiehm-st and
mathieuchopstm
The pipe nodes are not video interfaces. Describe them as normal child nodes instead of using port/endpoint. Signed-off-by: Phi Bang Nguyen <[email protected]>
ngphibang
force-pushed
the
fix_dcmipp_devicetree
branch
from
9dcba5b to
1ea37c5
Compare
|
| pipes { | ||
| compatible = "st,stm32-dcmipp-pipes"; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| port@0 { | ||
| pipe_dump: pipe@0 { | ||
| reg = <0>; | ||
|
|
||
| endpoint { | ||
| remote-endpoint-label = ""; | ||
| bus-type = <VIDEO_BUS_TYPE_PARALLEL>; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
By reviewing #94081, it seems only n6 has multiple pipes and this one has just one pipe ? In this case, pipes {} node is not needed and we can remove compatible string too. Otherwise, need to add an if in the dcmipp driver when retrieving the pipe / pipes:
DT_FOREACH_CHILD_VARGS(DT_INST_CHILD(inst, pipes), DCMIPP_PIPE_INIT_DEFINE, inst);
There was a problem hiding this comment.
Yes, only the N6 has several pipe. Others have single pipe. Is that an issue to keep it as you propose with current patch ?
Aka always have pipes { } and below it one or more pipe@x entries ?
|
Thanks @ngphibang for the patches and sorry for the long delay for review/test/reply. I confirm this looks good to me and is working fine. #define STM32_DCMIPP_INIT(inst) \part is all modified while actually the only modification is related to the DT_FOREACH_CHILD_VARGS, making it hard to notice. |
Uh oh!
There was an error while loading. Please reload this page.